CentOS Bug Tracker - CentOS-7
View Issue Details
0010447CentOS-7kernelpublic2016-02-25 11:572017-12-29 17:33
Reporterbenkonrath 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionfixed 
PlatformOSOS Version
Product Version 
Target VersionFixed in Version 
abrt_hash
URL
Summary0010447: add support for touchpad and fn key support for MacBookPro 12,1 (early 2015)
DescriptionSupport for the touchpad and fn key support for MacBookPro 12,1 (early 2015) was included in kernel version 4.2. It looks like both the bcm5974 and the hid-apple drivers will need backports from kernel >= 4.2 for the touchpad and keyboard to work properly on this hardware.

This kernel.org bug report has the 3 final patches that when into the 4.2 kernel but there might be updates since then.

https://bugzilla.kernel.org/show_bug.cgi?id=96771

I filed an issue against the RHEL 7 kernel for these updates but they said that it wasn't possible to get this update since they don't have the hardware to test.

https://bugzilla.redhat.com/show_bug.cgi?id=1267894

If you can't update the drivers for whatever reason, would it be possible to change the hid-apple driver to be a module instead of compiled into the kernel? As far as I understand things, this would allow me to create create an independent updated module like the one that has been created for Ubuntu.

https://github.com/SicVolo/hid-apple-3.19

Thanks in advance for your help.
TagsNo tags attached.
Attached Filespatch bug10447.patch (18,915) 2016-03-09 18:05
https://bugs.centos.org/file_download.php?file_id=12656&type=bug

Notes
(0025848)
toracat   
2016-02-25 18:48   
We can consider the requests by through making modifications to the centosplus kernel.

I had a quick look at the hid_apple kernel option. It is not trivial to change it from Y to M. Apparently something is preventing one to make the change. I'm not sure what it is -- it is possible that other options may depend on it. I'm sorry to say that this is not something I can help with at the moment.

On the other hand, applying the referenced patches might be possible.
(0025892)
benkonrath   
2016-03-01 07:48   
The centosplus kernel would be fine. Is this issue ok for requesting the change to the centosplus kernel? Or should I file a new issue?

Having the patches backported / included would be perfect. I don't know how much work that is though. Thanks for your help.
(0025893)
toracat   
2016-03-01 09:03   
(Last edited: 2016-03-03 18:17)
*** note to self ***

https://kernel.googlesource.com/pub/scm/linux/kernel/git/groeck/linux-staging/+/dbe08116b87cdc2217f11a78b5b70e29068b7efd%5E1..dbe08116b87cdc2217f11a78b5b70e29068b7efd/

$ git describe dbe08116b87cdc2217f11a78b5b70e29068b7efd
v4.2-rc4-107-gdbe0811

commit a4a2c54560f2c57b88ba0283f141b44f594c2337
commit d58069265c9d15c04c9e3832cd1d9dffe9d4d5f6
commit efbd34702fb1cb66e08606a623a8a76f86b300f9
commit ab80ee3895a76f1beba35847911d89833fbb68ab

(0025894)
toracat   
2016-03-01 09:04   
@benkonrath

No need to file another bug. I will take a closer look at the patches.
(0025966)
toracat   
2016-03-09 18:05   
Patch candidate uploaded.
(0025975)
toracat   
2016-03-10 03:11   
I have uploaded a centosplus kernel set that has the patch applied (kernel-plus-3.10.0-327.10.1.el7.ay.centos.plus) for you to test:

http://people.centos.org/toracat/kernel/7/plus/bugs10447_10516/

Please note that the packages are not signed and are provided for testing purposes only.
(0026028)
benkonrath   
2016-03-14 07:14   
I just tested kernel-plus-3.10.0-327.10.1.el7.ay.centos.plus and it is working. Thanks for your help with this!
(0026031)
toracat   
2016-03-14 22:45   
Thanks for reporting back. The patch will be in the next update of the "official" plus kernel.
(0026265)
toracat   
2016-04-12 15:53   
kernel-plus-3.10.0-327.13.1 is out. It has the referenced patch.
(0027991)
toracat   
2016-11-24 16:04   
(Last edited: 2016-11-26 13:42)
@benkonrath

kernel-plus 3.10.0-514.el7 (the GA kernel for CentOS 7.3) continues to carry this patch. What's the status of the upstream BZ 1311957 you filed?

(0028001)
benkonrath   
2016-11-26 08:50   
@toracat

I think your referring to BZ 1267894. There hasn't been any movement on that issue. I assume that the last statement from a Red Hat employee still applies: the patch won't make it into RHEL because they don't have the hardware to test it. I'll request it again for RHEL 7.4 once CentOS 7.3 is officially out.
(0028002)
toracat   
2016-11-26 13:43   
OK, please keep us posted.
(0030769)
toracat   
2017-12-16 17:39   
Any update on this?
(0030830)
benkonrath   
2017-12-29 16:24   
I still need to use the CentOS-Plus kernel in 7.4. I think it's safe to assume that support for the MBP won't make it into RHEL 7.
(0030831)
toracat   
2017-12-29 17:33   
OK, I will close this ticket as 'resolved'. Should the status with RHEL change, please feel free to reopen.

Issue History
2016-02-25 11:57benkonrathNew Issue
2016-02-25 18:48toracatNote Added: 0025848
2016-02-25 18:48toracatStatusnew => assigned
2016-03-01 07:48benkonrathNote Added: 0025892
2016-03-01 09:03toracatNote Added: 0025893
2016-03-01 09:04toracatNote Added: 0025894
2016-03-03 18:14toracatNote Edited: 0025893bug_revision_view_page.php?bugnote_id=25893#r687
2016-03-03 18:17toracatNote Edited: 0025893bug_revision_view_page.php?bugnote_id=25893#r688
2016-03-09 18:05toracatFile Added: bug10447.patch
2016-03-09 18:05toracatNote Added: 0025966
2016-03-10 03:11toracatNote Added: 0025975
2016-03-14 07:14benkonrathNote Added: 0026028
2016-03-14 22:45toracatNote Added: 0026031
2016-04-12 15:53toracatNote Added: 0026265
2016-11-24 16:04toracatNote Added: 0027991
2016-11-24 16:04toracatStatusassigned => feedback
2016-11-26 08:50benkonrathNote Added: 0028001
2016-11-26 08:50benkonrathStatusfeedback => assigned
2016-11-26 13:42toracatNote Edited: 0027991bug_revision_view_page.php?bugnote_id=27991#r766
2016-11-26 13:43toracatNote Added: 0028002
2017-12-16 17:39toracatStatusassigned => feedback
2017-12-16 17:39toracatNote Added: 0030769
2017-12-29 16:24benkonrathNote Added: 0030830
2017-12-29 16:24benkonrathStatusfeedback => assigned
2017-12-29 17:33toracatNote Added: 0030831
2017-12-29 17:33toracatStatusassigned => resolved
2017-12-29 17:33toracatResolutionopen => fixed