View Issue Details

IDProjectCategoryView StatusLast Update
0016710CentOS-8kernelpublic2019-11-09 04:56
Reportertux808 
PrioritynormalSeveritytweakReproducibilityalways
Status newResolutionopen 
Product Version8.0.1905 
Target VersionFixed in Version 
Summary0016710: eth0 Budget exhaused after napi rescheduled
DescriptionThe IBM virtual ethernet driver's polling function continues
to process frames after rescheduling NAPI, resulting in a warning
if it exhausted its budget.

kernel 4.20 introduced the patch to correct the ibmveth driver.
Please also backport for CentOS-7-1908 ppc64le / power9 kernels.
Additional Informationfrom: https://lkml.org/lkml/2019/2/14/1549

Thomas Falcon <tlfalcon@linux.ibm.com>

[ Upstream commit e95d22c69b2c130ccce257b84daf283fd82d611e ]

The IBM virtual ethernet driver's polling function continues
to process frames after rescheduling NAPI, resulting in a warning
if it exhausted its budget. Do not restart polling after calling
napi_reschedule. Instead let frames be processed in the following
instance.

Signed-off-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/net/ethernet/ibm/ibmveth.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c
index 098d8764c0ea..dd71d5db7274 100644
--- a/drivers/net/ethernet/ibm/ibmveth.c
+++ b/drivers/net/ethernet/ibm/ibmveth.c
@@ -1313,7 +1313,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget)
     unsigned long lpar_rc;
     u16 mss = 0;
 
-restart_poll:
     while (frames_processed < budget) {
         if (!ibmveth_rxq_pending_buffer(adapter))
             break;
@@ -1401,7 +1400,6 @@ static int ibmveth_poll(struct napi_struct *napi, int budget)
             napi_reschedule(napi)) {
             lpar_rc = h_vio_signal(adapter->vdev->unit_address,
                            VIO_IRQ_DISABLE);
- goto restart_poll;
         }
     }
TagsNo tags attached.

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-11-09 04:56 tux808 New Issue