View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0005331 | CentOS-6 | redhat-rpm-config | public | 2011-12-21 12:58 | 2013-11-06 05:07 |
Reporter | nmarques | Assigned To | |||
Priority | urgent | Severity | major | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | 6.2 | ||||
Summary | 0005331: dist.sh script from redhat-rpm-config requires hacking | ||||
Description | There is currently a bug in 'redhat-rpm-config' that prevents the dist.sh script to return the proper values for "--dist" and "--disttype". This can be easilly fixed, being one of the potential approaches the attached patch (which requires most likely to be rebased for inclusion). Without this fix it's impossible to generate RPM's with mock with the 'el6' prefix. Please consider fixing this and releasing an update. --- dist.sh 2011-12-21 12:47:42.521578934 +0000 +++ dist.sh.fix 2011-12-21 12:47:31.952582944 +0000 @@ -25,7 +25,7 @@ } function check_rhel { - egrep -q "(Enterprise|Advanced)" $RELEASEFILE && echo $DISTNUM + egrep -q "(Enterprise|Advanced|CentOS)" $RELEASEFILE && echo $DISTNUM } function check_fedora { | ||||
Tags | QA-6.3, QA-6.5 | ||||
related to | 0003239 | resolved | kbsingh@karan.org | CentOS-5 | ?dist does not return a result on Centos 5 |
dist.patch (319 bytes)
--- dist.sh 2011-12-21 12:47:42.521578934 +0000 +++ dist.sh.fix 2011-12-21 12:47:31.952582944 +0000 @@ -25,7 +25,7 @@ } function check_rhel { - egrep -q "(Enterprise|Advanced)" $RELEASEFILE && echo $DISTNUM + egrep -q "(Enterprise|Advanced|CentOS)" $RELEASEFILE && echo $DISTNUM } function check_fedora { |
|
I confirm the issue, only --distnum is reported correctly After adding 'CentOS' to 'check_rhel' # ./dist.sh --dist .el6 ./dist.sh --disttype el |
|
Hi, I have no experience in CentOS development model or on how patches are submitted. If it helps I can submit a fix for this package, I only need to know which steps to follow. I have all interest in having this bug fixed as soon as possible, as I have some packaging depending on this fix. Please let me know if there's something I can do to help getting this fixed faster. Nelson |
|
I'm happy to push fix now, into 6.2/updates. Athmane, does that work ? | |
Yes, should work. | |
Bump. :-( This fix missed 6.3. Karanbir or Johnny, can this be pushed into 6.3/updates ? |
|
it's still an issue in 6.4 # rpm -qf /usr/lib/rpm/redhat/dist.sh redhat-rpm-config-9.0.3-42.el6.noarch # /usr/lib/rpm/redhat/dist.sh # uname -a Linux xxx 2.6.32-358.23.2.el6.x86_64 #1 SMP Wed Oct 16 18:37:12 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux # cat /etc/centos-release CentOS release 6.4 (Final) |
|
I confirm this. The next chance to fix will be either a 6.4 update (unlikely) or the 6.5 GA release. |
|
fixed in redhat-rpm-config-9.0.3-42.el6.centos.src.rpm (released as a 6.4 update) | |
Date Modified | Username | Field | Change |
---|---|---|---|
2011-12-21 12:58 | nmarques | New Issue | |
2011-12-21 12:58 | nmarques | File Added: dist.patch | |
2011-12-21 14:20 | athmane | Note Added: 0013987 | |
2011-12-21 14:20 | athmane | Status | new => confirmed |
2011-12-21 14:20 | athmane | Tag Attached: QA-6.3 | |
2011-12-21 14:46 | nmarques | Note Added: 0013989 | |
2011-12-21 20:51 | toracat | Product Version | 6.1 => 6.2 |
2011-12-27 17:45 | toracat | Relationship added | related to 0003239 |
2012-01-17 08:22 | kbsingh@karan.org | Note Added: 0014218 | |
2012-01-17 11:43 | athmane | Note Added: 0014225 | |
2012-07-21 20:55 | toracat | Note Added: 0015525 | |
2013-11-04 15:28 | Romario74 | Note Added: 0018294 | |
2013-11-04 16:31 | toracat | Note Added: 0018295 | |
2013-11-04 16:31 | toracat | Tag Attached: QA-6.5 | |
2013-11-06 05:07 | JohnnyHughes | Note Added: 0018300 | |
2013-11-06 05:07 | JohnnyHughes | Status | confirmed => resolved |
2013-11-06 05:07 | JohnnyHughes | Resolution | open => fixed |